Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_wasm): fix the WASM diagnostic printer #3349

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

leops
Copy link
Contributor

@leops leops commented Oct 6, 2022

Summary

The DiagnosticPrinter was broken since #3315 as it was not deserializing diagnostics from JS back into Rust with the correct type (it was using rome_diagnostics::Diagnostic instead of rome_diagnostics::v2::serde::Diagnostic). This should fix the outstanding issue of the Playground failing to print the diagnostics.

Test Plan

I've added a new case in the tests of the WASM API in @rometools/js-api to check the diagnostic printer works correctly

@leops leops requested a review from a team October 6, 2022 08:07
@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 32b0768
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/633e96e071d989000734817e

@leops leops temporarily deployed to netlify-playground October 6, 2022 08:07 Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing because the JS is not formatted

@leops leops temporarily deployed to netlify-playground October 6, 2022 08:50 Inactive
@ematipico ematipico added the A-Runtime Work around runtime label Oct 6, 2022
@ematipico ematipico added this to the 10.0.0 milestone Oct 6, 2022
@ematipico ematipico added the A-Tooling Area: our own build, development, and release tooling label Oct 6, 2022
@leops leops merged commit 42f4eea into main Oct 6, 2022
@leops leops deleted the fix/wasm-diagnostic-printer branch October 6, 2022 09:02
@leops leops added the A-Diagnostic Area: errors and diagnostics label Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Diagnostic Area: errors and diagnostics A-Runtime Work around runtime A-Tooling Area: our own build, development, and release tooling
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants